[breaking] remove writeStatic to align with Vite
#5618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b37d98e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Jul 19, 2022
5 tasks
gornostay25
pushed a commit
to gornostay25/svelte-adapter-bun
that referenced
this pull request
Jul 21, 2022
aloker
pushed a commit
to validData/svelte-adapter-azure-swa
that referenced
this pull request
Jul 25, 2022
writeStatic has been removed from the adapter API See sveltejs/kit#5618 fixes geoffrich#52
geoffrich
pushed a commit
to geoffrich/svelte-adapter-azure-swa
that referenced
this pull request
Jul 25, 2022
writeStatic has been removed from the adapter API See sveltejs/kit#5618 fixes #52
Karakatiza666
added a commit
to Karakatiza666/sveltekit-adapter-chrome-extension
that referenced
this pull request
Jul 30, 2022
elron
added a commit
to elron/sveltekit-adapter-wordpress-shortcode
that referenced
this pull request
Aug 10, 2022
[breaking] remove writeStatic to align with Vite #5618 (sveltejs/kit#5618)
elron
added a commit
to elron/sveltekit-adapter-wordpress-shortcode
that referenced
this pull request
Aug 10, 2022
Have writeClient write both the client and static files and remove writeStatic. This is a breaking change for adapter authors. [breaking] remove writeStatic to align with Vite #5618 sveltejs/kit#5618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have
writeClientwrite both the client and static files and removewriteStatic. This is a breaking change for adapter authors.If we were using Vite's
publicDirandbaseoptions it would put the static files into the client directory. This change will free us up to be able to utilize those options in the future. This change was prototyped in #5601, but it's getting too large and complicated, so I'm breaking it up.