-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] only route pages on the client-side #2656
Conversation
🦋 Changeset detectedLatest commit: efd5fb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2101f8d
to
91476ca
Compare
91476ca
to
8d71e2d
Compare
Discussions about |
Asked Rich about this on Discord:
|
@benmccann Is there an equivalent option when using |
you could just do |
thx for the tip @benmccann 👍 the only issue is that I lost the |
Right now we have to send a list of all endpoints to the client, but 99% of the time they aren't used for anything and so it's generally unnecessary bandwidth overhead.
Removing this means that developers need to put
rel="external"
on any link to an endpoint. This seems like a reasonable trade-off since it is very rare to link to endpoints. Endpoints are primarily gotten viafetch
which doesn't utilize the router.In addition to reducing the size of the client JS, it also will make it slightly easier to refactor out the router (#2611) since it will have one less concern to deal with