Skip to content

docs: change "Cloudflare Pages" title to just "Cloudflare" #13725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Apr 18, 2025

This PR includes a small change to the display titles of the adapter-cloudflare and adapter-cloudflare-workers doc pages to better distinguish them in the nav bar and page itself.

Cloudflare Pages -> Cloudflare
Cloudflare Workers -> Cloudflare Workers Sites


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added the documentation Improvements or additions to documentation label Apr 18, 2025
Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: fc42c0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@benmccann
Copy link
Member

Renaming "Cloudflare Pages" to just "Cloudflare" probably makes sense. I thought the other adapter was for Workers since we have a server-side component and that Workers Sites was only for static sites. I also wonder if "Cloudflare Workers (deprecated)" might help guide users to the correct location more quickly - though I'm not sure if that's too long to fit in the sidebar

It'd probably be nice to submit a companion PR to https://github.com/sveltejs/svelte.dev implementing a redirect from the old page to the new page

@eltigerchino
Copy link
Member Author

eltigerchino commented Apr 21, 2025

I thought the other adapter was for Workers since we have a server-side component and that Workers Sites was only for static sites.

Oh right. Yeah, probably better to leave it as "Cloudflare Workers".

I also wonder if "Cloudflare Workers (deprecated)" might help guide users to the correct location more quickly - though I'm not sure if that's too long to fit in the sidebar

It does look a bit long on the main navbar but looks alright on the the others. Screenshot below:

cloudflare workers deprecated title

It'd probably be nice to submit a companion PR to sveltejs/svelte.dev implementing a redirect from the old page to the new page

I had this thought too but fortunately there are no changes to the page link (only the title). The links are still https://svelte.dev/docs/kit/adapter-cloudflare-workers and https://svelte.dev/docs/kit/adapter-cloudflare

@benmccann benmccann merged commit b183244 into main Apr 21, 2025
18 checks passed
@benmccann benmccann deleted the docs-cloudflare-title branch April 21, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg:adapter-cloudflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants