-
-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: change "Cloudflare Pages" title to just "Cloudflare" #13725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Renaming "Cloudflare Pages" to just "Cloudflare" probably makes sense. I thought the other adapter was for Workers since we have a server-side component and that Workers Sites was only for static sites. I also wonder if "Cloudflare Workers (deprecated)" might help guide users to the correct location more quickly - though I'm not sure if that's too long to fit in the sidebar It'd probably be nice to submit a companion PR to https://github.com/sveltejs/svelte.dev implementing a redirect from the old page to the new page |
Oh right. Yeah, probably better to leave it as "Cloudflare Workers".
It does look a bit long on the main navbar but looks alright on the the others. Screenshot below:
I had this thought too but fortunately there are no changes to the page link (only the title). The links are still https://svelte.dev/docs/kit/adapter-cloudflare-workers and https://svelte.dev/docs/kit/adapter-cloudflare |
This PR includes a small change to the display titles of the adapter-cloudflare and adapter-cloudflare-workers doc pages to better distinguish them in the nav bar and page itself.
Cloudflare Pages -> Cloudflare
Cloudflare Workers -> Cloudflare Workers Sites
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits