Skip to content

chore: install docker built extensions on AMI #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 6, 2023
Merged

chore: install docker built extensions on AMI #539

merged 15 commits into from
Jun 6, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Feb 15, 2023 •
edited
Loading

What kind of change does this PR introduce?

closes #513

What is the current behavior?

Postgres AMI is built with a subset of flags used in docker image

What is the new behavior?

  • Install AMI postgres from the official Postgres PPA
  • Install AMI extensions from packages built in docker

Additional context

TODO:

  • delete unused playbooks

@sweatybridge sweatybridge force-pushed the ansi-dock branch 4 times, most recently from ee7bfb4 to 52ff548 Compare February 15, 2023 15:09
@sweatybridge sweatybridge changed the title chore: build extensions in docker from ansible chore: move docker built extensions to AMI May 18, 2023
@sweatybridge sweatybridge force-pushed the ansi-dock branch 5 times, most recently from 8728ba0 to 8b7502f Compare May 19, 2023 18:01
@sweatybridge sweatybridge marked this pull request as ready for review May 19, 2023 18:02
@sweatybridge sweatybridge requested a review from a team as a code owner May 19, 2023 18:02
@sweatybridge sweatybridge force-pushed the ansi-dock branch 17 times, most recently from 44e1a08 to 46d6522 Compare May 22, 2023 10:25
@sweatybridge sweatybridge mentioned this pull request May 23, 2023
Merged
@sweatybridge sweatybridge force-pushed the ansi-dock branch 5 times, most recently from f9517cd to 646ac32 Compare May 24, 2023 19:41
@sweatybridge sweatybridge force-pushed the ansi-dock branch 3 times, most recently from fefa998 to df2e3a7 Compare May 25, 2023 06:41
@sweatybridge sweatybridge mentioned this pull request Jun 2, 2023
Merged
@sweatybridge sweatybridge requested a review from pcnc June 5, 2023 09:23
@sweatybridge sweatybridge requested a review from darora June 5, 2023 21:12
pcnc
pcnc approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@pcnc pcnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep a trail related to performance-improvement work, benchmarks comparing current prod/PPA/current PR build performance can be found here:

AMI Build TPCB-like select-only simple-update Flags
15.1.0.75 150.575 ms 6.591 ms 17.112 ms -mcpu=native
15.1.0.86-rc1 112.694 ms 6.608 ms 17.834 ms Official PPA
15.1.0.89-rc1 109.967 ms 6.126 ms 16.505 ms PPA + mcpu

@sweatybridge sweatybridge merged commit d919353 into develop Jun 6, 2023
@sweatybridge sweatybridge deleted the ansi-dock branch June 6, 2023 14:28
This was referenced Jun 6, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcnc pcnc pcnc approved these changes

@darora darora Awaiting requested review from darora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Postgres bundled in Docker image from source to achieve parity with the AMI
2 participants
@sweatybridge @pcnc