Fix issues with radix char different from "." (#1326108) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21399e
to
b403e76
Compare
The fr_FR locale uses "," as a radix char so it can reveal potential issues.
b403e76
to
ba3ff2d
Compare
|
The unit tests pass, but the whole test suite fails because autotools don't know how to clean after themselves properly. |
It doesn't really understand locales and doesn't play with different radix chars well.
ba3ff2d
to
db18fc8
Compare
|
Looks good to me. |
vpodzime
added a commit
to vpodzime/libbytesize
that referenced
this pull request
Jan 27, 2017
Release 0.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MPFR library doesn't work well with locales and doesn't accept floats as strings if written in the current locale (e.g.
"1,5"infr_FR). Thus we need to take care about this ourselves.Plus we should run the unit tests with such a locale to reveal other potential issues.