-
Notifications
You must be signed in to change notification settings - Fork 1k
Add NUCLEO-C092RC variant #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I've made a first review, could you add also the generic (clock config, boards.txt, and reference in the README.md).
And fix the astyle issues.
*/ | ||
/* | ||
* Automatically generated from STM32C092R8Tx.xml, STM32C092RBTx.xml | ||
* CubeMX DB release 6.0.120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems not be a copy of the PeripheralPins.c version should be 6.0.140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly do not know how this one should have been generated. I had copied over the one from C071-RB first, but then copied the contents of the generic variant of the C092 with the necessary edits but not the header. So it's edited manually, which is probably not the way it should be 😅.
In any case, how is this file normally produced? Couldn't find it in the wiki.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom file is a copy of the one in the generic folder then edited manually to remove some pins.
variants/STM32C0xx/C092CBT_C092RBT_C092RC(I-T)/variant_NUCLEO_C092RC.h
Outdated
Show resolved
Hide resolved
variants/STM32C0xx/C092CBT_C092RBT_C092RC(I-T)/variant_NUCLEO_C092RC.cpp
Outdated
Show resolved
Hide resolved
…C092RC.h Co-authored-by: Frederic Pillon <[email protected]> Signed-off-by: Hugo <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]> Signed-off-by: Hugo <[email protected]>
Hm, you would expect that if you'd run astyle to fix formatting, that the same astyle would also pass all the formatting checks... |
Yes but they are rules and configuration to use. |
Summary
This PR fixes/implements the following bugs/features
USART3_IRQn
andUSART4_IRQn
toUSART3_4_IRQn
for STM32C0 processorsValidation
Code formatting
Notes
I mostly copied the variant files from the NUCLEO-C071RB variant, since both chips share the same pinout and most peripherals. I have not checked if FDCAN works, all else seems to work perfectly fine.