Skip to content

Add NUCLEO-C092RC variant #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

showengineer
Copy link

@showengineer showengineer commented May 22, 2025

Summary

This PR fixes/implements the following bugs/features

  • Adding NUCLEO-C092RC board as a variant
  • Maps USART3_IRQn and USART4_IRQn to USART3_4_IRQn for STM32C0 processors

Validation

  • Ensure CI build is passed.
  • Checked with CheckVariant sketch

Code formatting

  • Ensure AStyle check is passed thanks CI

Notes
I mostly copied the variant files from the NUCLEO-C071RB variant, since both chips share the same pinout and most peripherals. I have not checked if FDCAN works, all else seems to work perfectly fine.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @showengineer

Thanks for the PR.
I've made a first review, could you add also the generic (clock config, boards.txt, and reference in the README.md).
And fix the astyle issues.

*/
/*
* Automatically generated from STM32C092R8Tx.xml, STM32C092RBTx.xml
* CubeMX DB release 6.0.120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not be a copy of the PeripheralPins.c version should be 6.0.140

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly do not know how this one should have been generated. I had copied over the one from C071-RB first, but then copied the contents of the generic variant of the C092 with the necessary edits but not the header. So it's edited manually, which is probably not the way it should be 😅.

In any case, how is this file normally produced? Couldn't find it in the wiki.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom file is a copy of the one in the generic folder then edited manually to remove some pins.

@fpistm fpistm added the new variant Add support of new bard label May 22, 2025
@fpistm fpistm added this to the 2.11.0 milestone May 22, 2025
@fpistm fpistm mentioned this pull request May 22, 2025
84 tasks
@showengineer
Copy link
Author

showengineer commented May 22, 2025

Hm, you would expect that if you'd run astyle to fix formatting, that the same astyle would also pass all the formatting checks...

@fpistm
Copy link
Member

fpistm commented May 23, 2025

Hm, you would expect that if you'd run astyle to fix formatting, that the same astyle would also pass all the formatting checks...

Yes but they are rules and configuration to use.
See https://github.com/stm32duino/Arduino_Core_STM32/wiki/Astyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants