Implement lb target-pool add-target command
#281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a70686 to
7a1be16
Compare
7a1be16 to
a307067
Compare
DiogoFerrao
reviewed
May 6, 2024
internal/cmd/load-balancer/target-pool/add-target/add_target.go
Outdated
Show resolved
Hide resolved
internal/cmd/load-balancer/target-pool/add-target/add_target.go
Outdated
Show resolved
Hide resolved
DiogoFerrao
approved these changes
May 6, 2024
joaopalet
added a commit
that referenced
this pull request
May 8, 2024
* initial setup for the load balancer (#252) * initial setup for the load balancer * generate docs * add load-balancer to set and unset config commands * Onboard Load Balancer generate-payload command (#250) * onboard load-balancer generate-payload command * add go mod * generate docs * remove version from the default payload which will be used for create commands * Update description Co-authored-by: Vicente Pinto <[email protected]> * Update description Co-authored-by: Vicente Pinto <[email protected]> * split create and update payloads * move default create payload to a const * delete unused utils files * update docs * remove redundant var declaration --------- Co-authored-by: Vicente Pinto <[email protected]> * LoadBalancer Describe, List and Quota commands (#254) * initial setup for the load balancer * generate docs * Describe, list, quota * Remove duplicate * Uniformize descriptipnm * Add tables for listeners and target pools * Improve column name --------- Co-authored-by: Gökçe Gök Klingel <[email protected]> * Add config key (#261) * Fix LB describe (#262) * fix(deps): update module github.com/jedib0t/go-pretty/v6 to v6.5.8 (#257) Co-authored-by: Renovate Bot <[email protected]> * Postgresflex backup command improvements (#259) * change title to created at * add note about current backup schedule in long description * add backup schedule to the instance describe output * Update internal/cmd/postgresflex/backup/update-schedule/update_schedule.go Co-authored-by: João Palet <[email protected]> * update docs --------- Co-authored-by: João Palet <[email protected]> * Add config key * Fix nil pointer exception --------- Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: João Palet <[email protected]> * Fixes to lb list and describe (#265) * Fixes to lb list and describe * Add separator * Remove columns * Remove separators * remove separator * Merge changes from main (#269) * fix(deps): update module github.com/jedib0t/go-pretty/v6 to v6.5.8 (#257) Co-authored-by: Renovate Bot <[email protected]> * Postgresflex backup command improvements (#259) * change title to created at * add note about current backup schedule in long description * add backup schedule to the instance describe output * Update internal/cmd/postgresflex/backup/update-schedule/update_schedule.go Co-authored-by: João Palet <[email protected]> * update docs --------- Co-authored-by: João Palet <[email protected]> * Update changelog generation implementation (#263) * change recovery date format (#266) * update description and generate docs (#267) * Add debug logs to the CLI (#258) * Initial debug implementation * improve implementation * remove unused code * add documentation * address PR comments * fix linting * sort map keys before building debug string * Add testing to debug string builders * address PR comments * improve debug string construction * Debug the input model on all commands * add input model debugging to contribution guidelines --------- Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Diogo Ferrão <[email protected]> * Load balancer delete command (#270) * fix(deps): update module github.com/jedib0t/go-pretty/v6 to v6.5.8 (#257) Co-authored-by: Renovate Bot <[email protected]> * Postgresflex backup command improvements (#259) * change title to created at * add note about current backup schedule in long description * add backup schedule to the instance describe output * Update internal/cmd/postgresflex/backup/update-schedule/update_schedule.go Co-authored-by: João Palet <[email protected]> * update docs --------- Co-authored-by: João Palet <[email protected]> * Update changelog generation implementation (#263) * change recovery date format (#266) * Delete loadbalancer command * Update internal/cmd/load-balancer/delete/delete.go Co-authored-by: Diogo Ferrão <[email protected]> * Update internal/cmd/load-balancer/delete/delete_test.go Co-authored-by: Diogo Ferrão <[email protected]> * Changes after review --------- Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: João Palet <[email protected]> Co-authored-by: Diogo Ferrão <[email protected]> * Onboard load balancer create & update commands (#268) * onboard-create-command * remove fields that are not needed for create * remove fields that are not needed for create from default payload * remove privateAddress from update payload (read only field) * update generate payload to remove read-only fields from updatePayload * onboard update load balancer command * update description of update command * Update internal/cmd/load-balancer/create/create.go Co-authored-by: João Palet <[email protected]> * Update internal/cmd/load-balancer/create/create.go Co-authored-by: João Palet <[email protected]> * add GetProjectName * change instance name to load balancer name * set listener name to nil * abstract set listener name to nil in a function // add unit test * add debug logs to the create command * add debug logs to the generate payload command * add debug logs to the update command * Update test func name Co-authored-by: João Palet <[email protected]> * add additional listener to the unit test --------- Co-authored-by: João Palet <[email protected]> * LoadBalancer observability-credentials commands (#264) * Lb observability-credentials add command * Describe and update commands * Improve update command * List command * Generate docs * Add debug logs, uniformize descriptions * Fix unit tests * Update internal/cmd/load-balancer/observability-credentials/observability-credentials.go Co-authored-by: GokceGK <[email protected]> * Update internal/cmd/load-balancer/observability-credentials/delete/delete_test.go Co-authored-by: GokceGK <[email protected]> --------- Co-authored-by: GokceGK <[email protected]> * Nil checks on lb describe (#273) * Fix examples (#275) * Implement `lb target-pool add-target` command (#281) * Add debug logs to list, describe and quota * Add utils and tests * Implement add-target command * Fix lb list test * Improvements after review * Add docs * Implement `lb target-pool remove-target` command (#283) * Implement lb target-pool remove-target command * Add util to get target name * Generate docs * Fix linter * Make target pool name the argument and LB name a flag * Update docs * Load balancer target pool commands improvements (#294) * Fix command example * Add n shorthand to target-name flag * Onboard load-balancer target-pool describe (#292) * initial describe command implementation * generate docs, fix linting * remove unused vars * rename flag * generate docs * rename vars * address PR comments * make JSON output match table * Tidy go.mod * Make pretty the default output for LB describe commands * Prompt for password when adding credentials before prompt for confirmation * Fix capitalization in example * Add middleware to LB client if verbosity is debug * change flag name in the example * update docs * Move password prompt before confirmation prompt in credentials update * Make IP an argument in add-target and remove-target * Support reading password from flag in add and update observablity credentials * Add error description to LB describe table * Update docs * Improve examples of LB observability credentials commands * Extend example --------- Co-authored-by: GokceGK <[email protected]> Co-authored-by: Gökçe Gök Klingel <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: João Palet <[email protected]> Co-authored-by: Diogo Ferrão <[email protected]> Co-authored-by: João Palet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.