Bug fix #243
Merged
Bug fix #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopalet
approved these changes
Apr 24, 2024
DiogoFerrao
added a commit
that referenced
this pull request
Apr 24, 2024
* Onboard Argus Scrape Configs: generate-payload command (#231) * Initial implementation * add utils, testing and make command work * implement function to create default create config * update help, improve testing and remove verification when job name is not provided * Improve testing * address PR comments * improve variable names * update command help * address PR comments * fix utils testing * Onboard Argus Scrape Config: create command (#233) * implement command and testing * remove TODO * address PR comments * address PR comments * Onboard Argus Scrape Config: delete command (#235) * delete command implementation and testing * improve help and log messages * update help * address PR comments * generate docs * Onboard Argus Scrape Configs: update command (#236) * delete command implementation and testing * initial implementation * finish implementation * generate docs * cleanup * remove json files * Address PR comments * generate docs * add comment about async method * Onboard Argus scrape config: list and describe commands (#240) * delete command implementation and testing * initial implementation * finish implementation * remove json files * list command implementation and testing * describe command implementation and testing * verify pointer before dereference * add config name to confirmation prompt in create cmd * generate docs * improve describe output * improve describe output * address PR comments * Merge main (#241) * Add `argus grafana describe` command (#221) * Add `argus grafana config describe` command * Extend command to also show dashboard URL * Generate docs * Improve command descriptions * Adjust function names * Show initial Grafana credentials in output * Add example for showing password * Change to hide-password flag * Update GitHub actions (#223) * Implemnt util for Argus grafana configuration commands (#224) * Add `argus grafana single-sign-on` commands (#228) * Add argus grafana single-sign-on enable command * Add argus grafana single-sign-on disable command * Update docs * Register disable command and update docs * Improvements after review * Add repology packaging status badge to INSTALLATION docs (#215) * Add argus grafana `public-read-access` commands (#229) * Copy files from single sign-on * Adaptations for the public-read-access commands * Update docs * Improvements after review * Move instance ID to argument * Adapt examples * Change config handling: only create config file & directory if needed (#214) * Change config handling: only create config file & directory if needed * Changes from code review * Fix config read * correctly handle f.Close error * chore(deps): update renovatebot/github-action action to v40.1.9 (#225) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.13.0 (#226) Co-authored-by: Renovate Bot <[email protected]> * Improvements for argus grafana commands (#230) * Add debug error logs (#217) * add error debug logs to clients * add error debug logs to refreshToken * add error debug logs to label fetching * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * add error debug logs to flag conversions * add printer to argus grafana commands * add debug log to getBearerToken function * fix debug messages on clients * Update internal/pkg/flags/flag_to_value.go Co-authored-by: Vicente Pinto <[email protected]> * remove obsolete err from the debug messages * make printer first parameter * add printer to new argus commands * Update internal/pkg/auth/user_token_flow.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/cmd/root.go Co-authored-by: Vicente Pinto <[email protected]> * fix linting problem * add string formatting to the printer debug function * set source in log handler to false --------- Co-authored-by: Vicente Pinto <[email protected]> * change order of debug and error logs (#232) * Output format none (#234) * Output format none * Add unit test, move const to print pkg * Switch usage of const * Signature (#237) * update docs for output format none addition (#239) * merge main * add error level debug logs to scrape config commands --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]> * fix seg fault on create with no payload (#243) --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]>
DiogoFerrao
added a commit
that referenced
this pull request
Apr 24, 2024
* Add `argus grafana describe` command (#221) * Add `argus grafana config describe` command * Extend command to also show dashboard URL * Generate docs * Improve command descriptions * Adjust function names * Show initial Grafana credentials in output * Add example for showing password * Change to hide-password flag * Update GitHub actions (#223) * Implemnt util for Argus grafana configuration commands (#224) * Add `argus grafana single-sign-on` commands (#228) * Add argus grafana single-sign-on enable command * Add argus grafana single-sign-on disable command * Update docs * Register disable command and update docs * Improvements after review * Add repology packaging status badge to INSTALLATION docs (#215) * Add argus grafana `public-read-access` commands (#229) * Copy files from single sign-on * Adaptations for the public-read-access commands * Update docs * Improvements after review * Move instance ID to argument * Adapt examples * Change config handling: only create config file & directory if needed (#214) * Change config handling: only create config file & directory if needed * Changes from code review * Fix config read * correctly handle f.Close error * chore(deps): update renovatebot/github-action action to v40.1.9 (#225) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.13.0 (#226) Co-authored-by: Renovate Bot <[email protected]> * Improvements for argus grafana commands (#230) * Add debug error logs (#217) * add error debug logs to clients * add error debug logs to refreshToken * add error debug logs to label fetching * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * add error debug logs to flag conversions * add printer to argus grafana commands * add debug log to getBearerToken function * fix debug messages on clients * Update internal/pkg/flags/flag_to_value.go Co-authored-by: Vicente Pinto <[email protected]> * remove obsolete err from the debug messages * make printer first parameter * add printer to new argus commands * Update internal/pkg/auth/user_token_flow.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/cmd/root.go Co-authored-by: Vicente Pinto <[email protected]> * fix linting problem * add string formatting to the printer debug function * set source in log handler to false --------- Co-authored-by: Vicente Pinto <[email protected]> * change order of debug and error logs (#232) * Output format none (#234) * Output format none * Add unit test, move const to print pkg * Switch usage of const * Signature (#237) * update docs for output format none addition (#239) * Add json output format (#238) * fix typo in error message * remove unused flag * add json output format for the responses * fix linting * adapt some parameters in Contribution file * change globalflags to print to use json format * Update internal/cmd/opensearch/credentials/create/create.go Co-authored-by: Vicente Pinto <[email protected]> * remove redundant error from return values of config list * shift switch case in the outputResult function --------- Co-authored-by: Vicente Pinto <[email protected]> * Update docs (#244) * Onboard Argus scrape configurations (#242) * Onboard Argus Scrape Configs: generate-payload command (#231) * Initial implementation * add utils, testing and make command work * implement function to create default create config * update help, improve testing and remove verification when job name is not provided * Improve testing * address PR comments * improve variable names * update command help * address PR comments * fix utils testing * Onboard Argus Scrape Config: create command (#233) * implement command and testing * remove TODO * address PR comments * address PR comments * Onboard Argus Scrape Config: delete command (#235) * delete command implementation and testing * improve help and log messages * update help * address PR comments * generate docs * Onboard Argus Scrape Configs: update command (#236) * delete command implementation and testing * initial implementation * finish implementation * generate docs * cleanup * remove json files * Address PR comments * generate docs * add comment about async method * Onboard Argus scrape config: list and describe commands (#240) * delete command implementation and testing * initial implementation * finish implementation * remove json files * list command implementation and testing * describe command implementation and testing * verify pointer before dereference * add config name to confirmation prompt in create cmd * generate docs * improve describe output * improve describe output * address PR comments * Merge main (#241) * Add `argus grafana describe` command (#221) * Add `argus grafana config describe` command * Extend command to also show dashboard URL * Generate docs * Improve command descriptions * Adjust function names * Show initial Grafana credentials in output * Add example for showing password * Change to hide-password flag * Update GitHub actions (#223) * Implemnt util for Argus grafana configuration commands (#224) * Add `argus grafana single-sign-on` commands (#228) * Add argus grafana single-sign-on enable command * Add argus grafana single-sign-on disable command * Update docs * Register disable command and update docs * Improvements after review * Add repology packaging status badge to INSTALLATION docs (#215) * Add argus grafana `public-read-access` commands (#229) * Copy files from single sign-on * Adaptations for the public-read-access commands * Update docs * Improvements after review * Move instance ID to argument * Adapt examples * Change config handling: only create config file & directory if needed (#214) * Change config handling: only create config file & directory if needed * Changes from code review * Fix config read * correctly handle f.Close error * chore(deps): update renovatebot/github-action action to v40.1.9 (#225) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.13.0 (#226) Co-authored-by: Renovate Bot <[email protected]> * Improvements for argus grafana commands (#230) * Add debug error logs (#217) * add error debug logs to clients * add error debug logs to refreshToken * add error debug logs to label fetching * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * add error debug logs to flag conversions * add printer to argus grafana commands * add debug log to getBearerToken function * fix debug messages on clients * Update internal/pkg/flags/flag_to_value.go Co-authored-by: Vicente Pinto <[email protected]> * remove obsolete err from the debug messages * make printer first parameter * add printer to new argus commands * Update internal/pkg/auth/user_token_flow.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/cmd/root.go Co-authored-by: Vicente Pinto <[email protected]> * fix linting problem * add string formatting to the printer debug function * set source in log handler to false --------- Co-authored-by: Vicente Pinto <[email protected]> * change order of debug and error logs (#232) * Output format none (#234) * Output format none * Add unit test, move const to print pkg * Switch usage of const * Signature (#237) * update docs for output format none addition (#239) * merge main * add error level debug logs to scrape config commands --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]> * fix seg fault on create with no payload (#243) --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]> * Add error level debug logs to commands --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]>
DiogoFerrao
added a commit
that referenced
this pull request
Apr 26, 2024
* Onboard Argus credentials: create command (#216) * argus credentials create command implementation * improve documentation, add test cases for hide-password * Onboard Argus credentials: delete and list commands (#222) * argus credentials delete command implementation * add documentation * update examples * argus credentials list command implementation * remove hide password flag from create * Improve info messages * improve create help * Argus Credentials: Merge main and add error level debug logs (#245) * Add `argus grafana describe` command (#221) * Add `argus grafana config describe` command * Extend command to also show dashboard URL * Generate docs * Improve command descriptions * Adjust function names * Show initial Grafana credentials in output * Add example for showing password * Change to hide-password flag * Update GitHub actions (#223) * Implemnt util for Argus grafana configuration commands (#224) * Add `argus grafana single-sign-on` commands (#228) * Add argus grafana single-sign-on enable command * Add argus grafana single-sign-on disable command * Update docs * Register disable command and update docs * Improvements after review * Add repology packaging status badge to INSTALLATION docs (#215) * Add argus grafana `public-read-access` commands (#229) * Copy files from single sign-on * Adaptations for the public-read-access commands * Update docs * Improvements after review * Move instance ID to argument * Adapt examples * Change config handling: only create config file & directory if needed (#214) * Change config handling: only create config file & directory if needed * Changes from code review * Fix config read * correctly handle f.Close error * chore(deps): update renovatebot/github-action action to v40.1.9 (#225) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.13.0 (#226) Co-authored-by: Renovate Bot <[email protected]> * Improvements for argus grafana commands (#230) * Add debug error logs (#217) * add error debug logs to clients * add error debug logs to refreshToken * add error debug logs to label fetching * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * add error debug logs to flag conversions * add printer to argus grafana commands * add debug log to getBearerToken function * fix debug messages on clients * Update internal/pkg/flags/flag_to_value.go Co-authored-by: Vicente Pinto <[email protected]> * remove obsolete err from the debug messages * make printer first parameter * add printer to new argus commands * Update internal/pkg/auth/user_token_flow.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/cmd/root.go Co-authored-by: Vicente Pinto <[email protected]> * fix linting problem * add string formatting to the printer debug function * set source in log handler to false --------- Co-authored-by: Vicente Pinto <[email protected]> * change order of debug and error logs (#232) * Output format none (#234) * Output format none * Add unit test, move const to print pkg * Switch usage of const * Signature (#237) * update docs for output format none addition (#239) * Add json output format (#238) * fix typo in error message * remove unused flag * add json output format for the responses * fix linting * adapt some parameters in Contribution file * change globalflags to print to use json format * Update internal/cmd/opensearch/credentials/create/create.go Co-authored-by: Vicente Pinto <[email protected]> * remove redundant error from return values of config list * shift switch case in the outputResult function --------- Co-authored-by: Vicente Pinto <[email protected]> * Update docs (#244) * Onboard Argus scrape configurations (#242) * Onboard Argus Scrape Configs: generate-payload command (#231) * Initial implementation * add utils, testing and make command work * implement function to create default create config * update help, improve testing and remove verification when job name is not provided * Improve testing * address PR comments * improve variable names * update command help * address PR comments * fix utils testing * Onboard Argus Scrape Config: create command (#233) * implement command and testing * remove TODO * address PR comments * address PR comments * Onboard Argus Scrape Config: delete command (#235) * delete command implementation and testing * improve help and log messages * update help * address PR comments * generate docs * Onboard Argus Scrape Configs: update command (#236) * delete command implementation and testing * initial implementation * finish implementation * generate docs * cleanup * remove json files * Address PR comments * generate docs * add comment about async method * Onboard Argus scrape config: list and describe commands (#240) * delete command implementation and testing * initial implementation * finish implementation * remove json files * list command implementation and testing * describe command implementation and testing * verify pointer before dereference * add config name to confirmation prompt in create cmd * generate docs * improve describe output * improve describe output * address PR comments * Merge main (#241) * Add `argus grafana describe` command (#221) * Add `argus grafana config describe` command * Extend command to also show dashboard URL * Generate docs * Improve command descriptions * Adjust function names * Show initial Grafana credentials in output * Add example for showing password * Change to hide-password flag * Update GitHub actions (#223) * Implemnt util for Argus grafana configuration commands (#224) * Add `argus grafana single-sign-on` commands (#228) * Add argus grafana single-sign-on enable command * Add argus grafana single-sign-on disable command * Update docs * Register disable command and update docs * Improvements after review * Add repology packaging status badge to INSTALLATION docs (#215) * Add argus grafana `public-read-access` commands (#229) * Copy files from single sign-on * Adaptations for the public-read-access commands * Update docs * Improvements after review * Move instance ID to argument * Adapt examples * Change config handling: only create config file & directory if needed (#214) * Change config handling: only create config file & directory if needed * Changes from code review * Fix config read * correctly handle f.Close error * chore(deps): update renovatebot/github-action action to v40.1.9 (#225) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.13.0 (#226) Co-authored-by: Renovate Bot <[email protected]> * Improvements for argus grafana commands (#230) * Add debug error logs (#217) * add error debug logs to clients * add error debug logs to refreshToken * add error debug logs to label fetching * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/pkg/services/argus/client/client.go Co-authored-by: Vicente Pinto <[email protected]> * add error debug logs to flag conversions * add printer to argus grafana commands * add debug log to getBearerToken function * fix debug messages on clients * Update internal/pkg/flags/flag_to_value.go Co-authored-by: Vicente Pinto <[email protected]> * remove obsolete err from the debug messages * make printer first parameter * add printer to new argus commands * Update internal/pkg/auth/user_token_flow.go Co-authored-by: Vicente Pinto <[email protected]> * Update internal/cmd/root.go Co-authored-by: Vicente Pinto <[email protected]> * fix linting problem * add string formatting to the printer debug function * set source in log handler to false --------- Co-authored-by: Vicente Pinto <[email protected]> * change order of debug and error logs (#232) * Output format none (#234) * Output format none * Add unit test, move const to print pkg * Switch usage of const * Signature (#237) * update docs for output format none addition (#239) * merge main * add error level debug logs to scrape config commands --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]> * fix seg fault on create with no payload (#243) --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]> * Add error level debug logs to commands --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]> --------- Co-authored-by: João Palet <[email protected]> Co-authored-by: GokceGK <[email protected]> Co-authored-by: Kumm-Kai <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Vicente Pinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.