-
Notifications
You must be signed in to change notification settings - Fork 15
SKE Credentials Rotation: deprecate old commands #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DiogoFerrao
merged 2 commits into
feature-ske-new-credentials-rotation
from
df/deprecate-old-credentials-commands
Apr 3, 2024
Merged
SKE Credentials Rotation: deprecate old commands #191
DiogoFerrao
merged 2 commits into
feature-ske-new-credentials-rotation
from
df/deprecate-old-credentials-commands
Apr 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicentepinto98
approved these changes
Apr 3, 2024
a3a693a
into
feature-ske-new-credentials-rotation
3 checks passed
DiogoFerrao
added a commit
that referenced
this pull request
Apr 3, 2024
* SKE Credentials Rotation: start-rotation command (#179) * initial start rotation command implementation * update go mod, rename files, generate docs * start-rotation update long description * Improve start-rotation documentation * SKE Credentials Rotation: complete-rotation command (#181) * initial complete rotation command * complete rotation command: improve documentation * improve documentation * SKE Credentials Rotation: kubeconfig create command (#184) * initial kubeconfig create command * finish create command implementation, add testing * fix linting, generate docs * address PR comments * extract funcs to utils, add testing * improve function documentation * fix linting * address PR comments, minor improvements * make utils testing work on all OSes * SKE Credentials Rotation: fixes and improvements (#188) * improve docs * Improve documentation, address acceptance comments * fix testing, finish renaming filepath flag * SKE Credentials Rotation: deprecate old commands (#191) * deprecate describe and rotate commands * improve deprecation messages, add docs * SKE Credentials Rotation: deprecate old commands improvements (#192) * remove example cluster name from deprecation message * address comments
DiogoFerrao
added a commit
that referenced
this pull request
Apr 8, 2024
* fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.11.0 (#180) Co-authored-by: Renovate Bot <[email protected]> * Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#183) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Only write to config file when needed (#185) * UX improvements (#187) * add default to project list * project list: improve implementation, add testing * Fix examples in project list * Add version column to plans in DSAs * Add dns record data to list and describe * minor improvements to code * fix linting * add docs * change keyring testing * address comments in PR * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/postgresflex to v0.11.0 (#189) Co-authored-by: Renovate Bot <[email protected]> * UX Improvements: fixes and improvements (#190) * add default to project list * project list: improve implementation, add testing * minor improvements to code * fix linting * change keyring testing * address comments in PR * address PR comments * generate docs * Update internal/pkg/args/args.go Co-authored-by: João Palet <[email protected]> * fix linting --------- Co-authored-by: João Palet <[email protected]> * Add support for SKE new credentials rotation flow (#186) * SKE Credentials Rotation: start-rotation command (#179) * initial start rotation command implementation * update go mod, rename files, generate docs * start-rotation update long description * Improve start-rotation documentation * SKE Credentials Rotation: complete-rotation command (#181) * initial complete rotation command * complete rotation command: improve documentation * improve documentation * SKE Credentials Rotation: kubeconfig create command (#184) * initial kubeconfig create command * finish create command implementation, add testing * fix linting, generate docs * address PR comments * extract funcs to utils, add testing * improve function documentation * fix linting * address PR comments, minor improvements * make utils testing work on all OSes * SKE Credentials Rotation: fixes and improvements (#188) * improve docs * Improve documentation, address acceptance comments * fix testing, finish renaming filepath flag * SKE Credentials Rotation: deprecate old commands (#191) * deprecate describe and rotate commands * improve deprecation messages, add docs * SKE Credentials Rotation: deprecate old commands improvements (#192) * remove example cluster name from deprecation message * address comments * UX improvements: update project describe help (#193) * update project describe examples * generate docs * Onboard PostgreSQL Flex force delete (#194) * update create examples to existing flavor * add the --force flag to delete command * generate docs * add forcedeleteinstance waiter * extract deletion logic to function, test it. Address PR comments * fix linting, generate docs * rename util function * update sdk version * change new methods to print package * update testing to include verbosity, update docs --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: João Palet <[email protected]>
DiogoFerrao
added a commit
that referenced
this pull request
Apr 8, 2024
* fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.11.0 (#180) Co-authored-by: Renovate Bot <[email protected]> * Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#183) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Only write to config file when needed (#185) * UX improvements (#187) * add default to project list * project list: improve implementation, add testing * Fix examples in project list * Add version column to plans in DSAs * Add dns record data to list and describe * minor improvements to code * fix linting * add docs * change keyring testing * address comments in PR * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/postgresflex to v0.11.0 (#189) Co-authored-by: Renovate Bot <[email protected]> * UX Improvements: fixes and improvements (#190) * add default to project list * project list: improve implementation, add testing * minor improvements to code * fix linting * change keyring testing * address comments in PR * address PR comments * generate docs * Update internal/pkg/args/args.go Co-authored-by: João Palet <[email protected]> * fix linting --------- Co-authored-by: João Palet <[email protected]> * Add support for SKE new credentials rotation flow (#186) * SKE Credentials Rotation: start-rotation command (#179) * initial start rotation command implementation * update go mod, rename files, generate docs * start-rotation update long description * Improve start-rotation documentation * SKE Credentials Rotation: complete-rotation command (#181) * initial complete rotation command * complete rotation command: improve documentation * improve documentation * SKE Credentials Rotation: kubeconfig create command (#184) * initial kubeconfig create command * finish create command implementation, add testing * fix linting, generate docs * address PR comments * extract funcs to utils, add testing * improve function documentation * fix linting * address PR comments, minor improvements * make utils testing work on all OSes * SKE Credentials Rotation: fixes and improvements (#188) * improve docs * Improve documentation, address acceptance comments * fix testing, finish renaming filepath flag * SKE Credentials Rotation: deprecate old commands (#191) * deprecate describe and rotate commands * improve deprecation messages, add docs * SKE Credentials Rotation: deprecate old commands improvements (#192) * remove example cluster name from deprecation message * address comments * UX improvements: update project describe help (#193) * update project describe examples * generate docs * Onboard PostgreSQL Flex force delete (#194) * update create examples to existing flavor * add the --force flag to delete command * generate docs * add forcedeleteinstance waiter * extract deletion logic to function, test it. Address PR comments * fix linting, generate docs * rename util function * update sdk version * Re-add APT installation instructions with new domain (#195) * Revert "Temporarily remove APT installation instructions from guide (#162)" This reverts commit 64faf39. * Replace APT repo URL * fix(deps): update module golang.org/x/oauth2 to v0.19.0 (#197) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update module golang.org/x/mod to v0.17.0 (#196) * Update module golang.org/x/mod to v0.16.0 * fix(deps): update module golang.org/x/mod to v0.17.0 --------- Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: vicentepinto98 <[email protected]> * fix(deps): update module github.com/jedib0t/go-pretty/v6 to v6.5.8 (#199) Co-authored-by: Renovate Bot <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: João Palet <[email protected]> Co-authored-by: vicentepinto98 <[email protected]>
DiogoFerrao
added a commit
that referenced
this pull request
Apr 8, 2024
* fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/ske to v0.11.0 (#180) Co-authored-by: Renovate Bot <[email protected]> * Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#183) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Only write to config file when needed (#185) * UX improvements (#187) * add default to project list * project list: improve implementation, add testing * Fix examples in project list * Add version column to plans in DSAs * Add dns record data to list and describe * minor improvements to code * fix linting * add docs * change keyring testing * address comments in PR * fix(deps): update module github.com/stackitcloud/stackit-sdk-go/services/postgresflex to v0.11.0 (#189) Co-authored-by: Renovate Bot <[email protected]> * UX Improvements: fixes and improvements (#190) * add default to project list * project list: improve implementation, add testing * minor improvements to code * fix linting * change keyring testing * address comments in PR * address PR comments * generate docs * Update internal/pkg/args/args.go Co-authored-by: João Palet <[email protected]> * fix linting --------- Co-authored-by: João Palet <[email protected]> * Add support for SKE new credentials rotation flow (#186) * SKE Credentials Rotation: start-rotation command (#179) * initial start rotation command implementation * update go mod, rename files, generate docs * start-rotation update long description * Improve start-rotation documentation * SKE Credentials Rotation: complete-rotation command (#181) * initial complete rotation command * complete rotation command: improve documentation * improve documentation * SKE Credentials Rotation: kubeconfig create command (#184) * initial kubeconfig create command * finish create command implementation, add testing * fix linting, generate docs * address PR comments * extract funcs to utils, add testing * improve function documentation * fix linting * address PR comments, minor improvements * make utils testing work on all OSes * SKE Credentials Rotation: fixes and improvements (#188) * improve docs * Improve documentation, address acceptance comments * fix testing, finish renaming filepath flag * SKE Credentials Rotation: deprecate old commands (#191) * deprecate describe and rotate commands * improve deprecation messages, add docs * SKE Credentials Rotation: deprecate old commands improvements (#192) * remove example cluster name from deprecation message * address comments * UX improvements: update project describe help (#193) * update project describe examples * generate docs * Onboard PostgreSQL Flex force delete (#194) * update create examples to existing flavor * add the --force flag to delete command * generate docs * add forcedeleteinstance waiter * extract deletion logic to function, test it. Address PR comments * fix linting, generate docs * rename util function * update sdk version * Re-add APT installation instructions with new domain (#195) * Revert "Temporarily remove APT installation instructions from guide (#162)" This reverts commit 64faf39. * Replace APT repo URL * fix(deps): update module golang.org/x/oauth2 to v0.19.0 (#197) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update module golang.org/x/mod to v0.17.0 (#196) * Update module golang.org/x/mod to v0.16.0 * fix(deps): update module golang.org/x/mod to v0.17.0 --------- Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: vicentepinto98 <[email protected]> * fix(deps): update module github.com/jedib0t/go-pretty/v6 to v6.5.8 (#199) Co-authored-by: Renovate Bot <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: João Palet <[email protected]> Co-authored-by: vicentepinto98 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.