-
Notifications
You must be signed in to change notification settings - Fork 15
Onboard Argus (instance): create command and utils #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DiogoFerrao
merged 8 commits into
feature-onboard-argus
from
df/onboard-argus-instances-create
Mar 11, 2024
Merged
Onboard Argus (instance): create command and utils #133
DiogoFerrao
merged 8 commits into
feature-onboard-argus
from
df/onboard-argus-instances-create
Mar 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopalet
reviewed
Mar 11, 2024
joaopalet
reviewed
Mar 11, 2024
joaopalet
approved these changes
Mar 11, 2024
joaopalet
added a commit
that referenced
this pull request
Mar 19, 2024
* Onboard Argus: plans command, config (set and unset) and client (#147) * Onboard Argus (instance): create command and utils (#133) * Onboard Argus instance: create command init * create command: complete functionality and start testing * create command: added testing for utils * update utils error message * Add custom Argus error and fix create command testing * fix error formatting in utils * fix error formatting * Onboard Argus (instance): update command (#149) * Onboard Argus Instance: update command * update command: support no plan info provided * update command: testing * fix linting * update command: handle empty instance name * update documentation * update command: handle empty name update and corner cases * fix linting * update command: improve error message * address comments in PR * Update internal/cmd/argus/instance/update/update.go Co-authored-by: João Palet <[email protected]> * fix linting --------- Co-authored-by: João Palet <[email protected]> * Onboard Argus (instance): delete command (#151) * Onboard Argus Instance: delete command * delete command: add docs * Onboard Argus (instance): list and describe commands (#155) * Onboard Argus Instance: list command * Onboard Argus Instance: describe command * describe command: dont display name if empty * describe command: update output * describe command: remove additional check * describe command: add grafana url * add docs and address comments * update command: improve examples, add name shorthand flag (#160) --------- Co-authored-by: João Palet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.