Skip to content

Investigate Upgrade to Jackson 3 #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophstrobl opened this issue May 16, 2025 · 3 comments
Open

Investigate Upgrade to Jackson 3 #3113

christophstrobl opened this issue May 16, 2025 · 3 comments

Comments

@christophstrobl
Copy link
Member

https://github.com/FasterXML/jackson/wiki/Jackson-Release-3.0

Related to: spring-projects/spring-data-commons#3292
Due to the amount of breaking changes the upgrade will have a broader impact.

@sothawo
Copy link
Collaborator

sothawo commented May 24, 2025

Did a first step (have a branch in my fork):

I had to change the dependencies and imports. Some adjustments where methods that have been renamed (or better the old ones had been deprecated). So far this works, BUT:

I hand a customized ObjectMapper into the JacksonJsonpMapper that is passed into the RestClient from Elasticsearch (the one ES uses by default discards null values, but sending null values to ES is a valid use case). And the JacksonJsonpMapper of course expect a com.fasterxml.jackson.databind.ObjectMapper.

I will need some more investigation how to address that.

@sothawo
Copy link
Collaborator

sothawo commented May 24, 2025

Looking at https://central.sonatype.com/artifact/co.elastic.clients/elasticsearch-java, the Elasticsearch client 9 references Jackson 2.18.3.

@sothawo
Copy link
Collaborator

sothawo commented May 24, 2025

ok, as Jackson changed the coordinates and package names, it is possible to use a version 2 ObjectMapper for the Elasticsearch client and version 3 for Spring Data Elasticsearch.

Not sure if this is a good idea, and what consequences this might have for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants