Optimized login form in security sample - delegated CSRF token creation to thymeleaf #1039
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I didn't know about that feature in thymeleaf. Can you confirm you filled out the contributor's agreement (link in README)? |
|
I've filled out the contributor's agreement. |
|
@jgayoso I try CSRF feature, it is cool and works for login. |
|
+1 |
|
No, you shouldn't have those attributes. Thymeleaf will add hidden form fields depending on Spring configuration. In this case, the csrf parameter will depend on Spring Security configuration. |
maciejwalkowiak
pushed a commit
to maciejwalkowiak/spring-boot
that referenced
this pull request
Jun 9, 2014
Also added additional test to verify behaviour. Fixes spring-projectsgh-1039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thymeleaf 2.1.x supports CSRF token.
http://www.thymeleaf.org/whatsnew21.html#reqdata
thymeleaf/thymeleaf-spring#7 (comment)