Skip to content

Inaccurate line tracing #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buckle2000 opened this issue May 15, 2017 · 1 comment
Closed

Inaccurate line tracing #12

buckle2000 opened this issue May 15, 2017 · 1 comment
Assignees

Comments

@buckle2000
Copy link

buckle2000 commented May 15, 2017

https://gist.github.com/buckle2000/68dad3f24613d37625e9c2f590dd3f52

Although the two lines should be symmetrical...

_20170515175419

But in reality, one line is one pixel offset, above the other.

@PaulZC
Copy link
Contributor

PaulZC commented Dec 11, 2020

Hi @buckle2000 ,

Thank you for raising this issue - and apologies for the very slow reply.

There was a small bug in the line function which meant that the last pixel was not being plotted. The offending line was this one. The equals was missing.

I've fixed this in version 1.2.10 and have added a new example (Example9) which demonstrates the correction. If you enable Serial debug messages using enableDebugging, you will see the coordinates of each pixel as it gets plotted.

Thanks again for spotting this.
Very best wishes,
Paul

@PaulZC PaulZC closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants