Skip to content

Client refactoring #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 27, 2015
Merged

Client refactoring #96

merged 12 commits into from
Sep 27, 2015

Conversation

alex35mil
Copy link
Member

  • Remove unused karma stuff
  • Remove unused gulp and setup npm lint scripts
  • Update webpack configs with app/vendor code splitting
  • Use only npm run scripts
  • Move js app to /client/app
  • Load initial data via props (after merge Bump react_on_rails gem version to 1.0.3 #99)

@justin808 Should we make /client/assets/javascripts -> /client/app transition here?

This was referenced Sep 18, 2015
Closed
Merged
@justin808
Copy link
Member

@alexfedoseev Yes, let's move /client/assets/javascripts to /client/app and update the README.md. Thanks!

dylangrafmyre
dylangrafmyre reviewed Sep 19, 2015
View reviewed changes
README.md
@@ -102,7 +102,7 @@ the JS bundle. We've chosen to let Rails handle CSS, SCSS, images, fonts.

```
cd client
$(npm bin)/webpack -w --config webpack.rails.config.js
npm run build:dev
```

`client-bundle.js` is generated and saved to `app/assets/javascripts`. This is included in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be changed to app-bundle.js and vendor-bundle.js?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylangrafmyre Nice catch! Will fix it today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexfedoseev @dylangrafmyre Should we also upgrade to current npm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and to current node also.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also when we upgrade to [email protected] we need to change the npm install/upgrade instructions in the client/REAMDE. shrinkwrap.json gets automatically updated during npm install/upgrade similar to Gemfile.loc.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By saying "yes", I meant current [email protected]. I suggest to wait a month or so before upgrade to 3.x.x, since there is performance issue.

@alex35mil alex35mil mentioned this pull request Sep 19, 2015
Merged
justin808
justin808 reviewed Sep 20, 2015
View reviewed changes
.gitignore
@@ -27,3 +25,6 @@ vendor/ruby

# RVM gemset
.ruby-gemset

# Generated js bundles
/app/assets/javascripts/generated/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@justin808
Copy link
Member

@alexfedoseev Let's try this out with the master on react_on_rails, and if that works, I'm going to push the next version of react_on_rails.

@justin808
Copy link
Member

I just pushed up the new version of https://rubygems.org/gems/react_on_rails. Let's get that in here, and let's put in server rendering.

This was referenced Sep 21, 2015
Merged
Closed
@alex35mil alex35mil mentioned this pull request Sep 23, 2015
Closed
@alex35mil
Copy link
Member Author

@justin808 Ready to review!
P.S. I haven't applied component-oriented structure and normalizr in this PR, will do it in the next one.

@justin808
Copy link
Member

@alexfedoseev Please update to the latest react_on_rails gem.
@samnang @dylangrafmyre Any feedback on this one?

@justin808
Copy link
Member

LGTM

@alex35mil
Copy link
Member Author

@justin808 I've updated gem to 0.1.5, but all html from server is escaped now: http://share.minima.pro/dMgm

@justin808
Copy link
Member

@alexfedoseev if all looks good, please merge and push latest to Heroku 👍

@dylangrafmyre
Copy link
Contributor

@justin808 FYI, Codeship automatically deploys to heroku any merges to master.

alex35mil added a commit that referenced this pull request Sep 27, 2015
@alex35mil
Merge pull request #96 from shakacode/client-refactoring
05a6d44 
Client refactoring
@alex35mil alex35mil merged commit 05a6d44 into master Sep 27, 2015
@alex35mil alex35mil deleted the client-refactoring branch September 27, 2015 21:16
@alex35mil
Copy link
Member Author

@justin808 @dylangrafmyre Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex35mil @justin808 @dylangrafmyre