Skip to content

Move jQuery and jQuery-ujs under /client and npm #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 12, 2015
Merged

Move jQuery and jQuery-ujs under /client and npm #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
879ecb2
Move jQuery and jQuery-ujs under /client and npm
dylangrafmyre Sep 11, 2015
6beab23
Remove jquery-rails gem, remove commented external jQuery from webpac…
dylangrafmyre Sep 11, 2015
2ace443
Remove require expose jQuery and jQuery-ujs from script/rails_only
dylangrafmyre Sep 11, 2015
78de2cb
Address eslint linting issue
dylangrafmyre Sep 11, 2015
851dc3c
Add additional jquery expose-loader to global $
dylangrafmyre Sep 11, 2015
208dc62
Update README.md referencing the jQuery expose and entry point within…
dylangrafmyre Sep 11, 2015
421cef2
Addrees suggest comments from PR
dylangrafmyre Sep 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ gem "coffee-rails"
# See https://github.com/sstephenson/execjs#readme for more supported runtimes
# gem "therubyracer", platforms: :ruby

# Use jquery as the JavaScript library
gem "jquery-rails"
# jquery as the JavaScript library has been moved under /client and managed by npm.
# It is critical to not include any of the jquery gems when following this pattern or
# else you might have multiple jQuery versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# It is critical to not include any of the jquery gems when following this pattern or else you might have multiple jQuery versions.

# Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks
gem "turbolinks"
# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
Expand Down
5 changes: 0 additions & 5 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ GEM
jbuilder (2.3.1)
activesupport (>= 3.0.0, < 5)
multi_json (~> 1.2)
jquery-rails (4.0.4)
rails-dom-testing (~> 1.0)
railties (>= 4.2.0)
thor (>= 0.14, < 2.0)
json (1.8.3)
kgio (2.9.3)
launchy (2.4.3)
Expand Down Expand Up @@ -275,7 +271,6 @@ DEPENDENCIES
factory_girl_rails
foreman
jbuilder
jquery-rails
launchy
pg
phantomjs
Expand Down
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,17 @@ Be sure to see [assets.rake](https://github.com/shakacode/react-webpack-rails-tu
The `webpack.rails.config.js` file generates client-bundle.js which is then included
by the Rails asset pipeline.

##jQuery with Rails and Webpack
jQuery and jQuery-ujs are not required within `app/assets/javascript/application.js`
and have been moved under`/client` and managed by npm. The modules are exposed via entry point
by `webpack.common.config.js`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

In `application.js`, it's critical that any libraries that depend on jQuery come after the inclusion of the Webpack bundle, such as the twitter bootstrap javascript.

Also, possibly the twitter bootstrap javascript should come from npm?

In `application.js`, it's critical that any libraries that depend on jQuery come after the inclusion
of the Webpack bundle, such as the twitter bootstrap javascript.

Please refer to [Considerations for jQuery with Rails and Webpack](http://forum.railsonmaui.com/t/considerations-for-jquery-with-rails-and-webpack/344) for further info.


## Sass and images
1. The Webpack server loads the images from the **symlink** of the
`app/assets/images` directory.
Expand Down
11 changes: 4 additions & 7 deletions app/assets/javascripts/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,11 @@
//
// Read Sprockets README (https://github.com/sstephenson/sprockets#sprockets-directives) for details
// about supported directives.
//
//= require jquery
//= require jquery_ujs

//= require bootstrap-sprockets

// Important to import jquery_ujs before rails-bundle as that patches jquery xhr to use the authenticity token!

// Need to be on top to allow Poltergeist test to work with React.
//= require es5-shim/es5-shim

// It is important that generated/client-bundle must be before bootstrap since it is exposing jQuery and jQuery-ujs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

//= require generated/client-bundle
//= require bootstrap-sprockets
//= require turbolinks
Loading