Skip to content

Add ror binstubs #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2023
Merged

Add ror binstubs #554

merged 2 commits into from
Sep 29, 2023

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Sep 15, 2023 •
edited by justin808
Loading

Add standard react_on_rails binstubs (bin/dev and bin/dev-static) for running the server.

This change is Reviewable

@ahangarha ahangarha requested a review from Judahmeek September 29, 2023 19:37
Judahmeek
Judahmeek approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@Judahmeek Judahmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question: where did these bin scripts come from?

Because react_on_rails doesn't have these scripts.

@Judahmeek Judahmeek merged commit 707686d into master Sep 29, 2023
@Judahmeek Judahmeek deleted the add-ror-binstubs branch September 29, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Judahmeek Judahmeek Judahmeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahangarha @Judahmeek