Test upgrade deps #547
Closed
Test upgrade deps #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Bump all minor and patch versions of all packages.
2. Upgrade `autoprefixer`: Use `.browserslistrc` and delete `.postcssrc`
Add it to `postcss.config.js`
Install and add `postcss-preset-env` to `postcss.config.js`
3. Upgrade `immutable`: Explicitly convert all `Array`s to `List`s
4. Upgrae `marked`: Install `marked-gfm-heading-id` to support `gfm` opt
5. Upgrade `react-router`:
a. Remove `exact`
b. Use `Routes` instead of `Switch`.
c. Import `StaticRouter` from `react-router-dom/server`.
d. Use `element` instead of `component`
e. Use absolute paths instead of relative in Links.
f. Convert Two Components to Functional React ones in order to use
`useLocation` hook.
g. Use `isActive` in `className` instead of `activeClassName`.
h. Use `Navigate` instead of `Redirect`.
i. Reset state once redirected.
6. Upgrade `react-transition-group`:
a. Use `TransitionGroup` and `CSSTransition` instead of
`ReactCSSTransitionGroup`.
b. Convert one component to a Functional React one to use `forwardRef`
c. Add `nodeRef` as part of the state to track DOM nodes for animation
7. Install `typescript` because it's a needed peer depenency of
`prettier-eslint-cli`
Signed-off-by: Khaled Emara <[email protected]>
This commit solve the warning of unexpected ref object provided for a div.
- Since we create the comment nodeRef in the CommentList component We don’t need it to be created during adding a comment. - We shouldn’t change the props of a react component, It is not the best practice, So that this commit creates the nodeRef in the render function where it is used instead of the constructor function.
|
No need for new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the upgrade deps branch.
This change is