Skip to content

Replace custom webpack configs with default #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 24, 2020
Merged

Replace custom webpack configs with default #477

merged 15 commits into from
Jul 24, 2020

Conversation

hussainakram
Copy link
Member

@hussainakram hussainakram commented Jul 15, 2020 •
edited by justin808
Loading

This change is Reviewable

@hussainakram hussainakram force-pushed the update-webpack-configs branch 3 times, most recently from 593ed18 to 2ad83a8 Compare July 15, 2020 16:38
@hussainakram hussainakram force-pushed the update-webpack-configs branch from e31f86c to 7688a6c Compare July 16, 2020 07:53
@hussainakram
remove old assets
2f4f50b 
update babel configs
update linters
@justin808
Copy link
Member

This looks great!

@justin808 justin808 merged commit 8e656f9 into master Jul 24, 2020
@justin808 justin808 deleted the update-webpack-configs branch July 24, 2020 09:22
@cirosantilli cirosantilli mentioned this pull request Apr 2, 2021
Closed
@cirosantilli
Copy link

Hi Hussain, I noticed this PR seems to remove the hot-assets script at https://github.com/shakacode/react-webpack-rails-tutorial/pull/477/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L23 , which Procfile.hot , which is mentioned on the README.md getting started, depends on: #488 (comment) Any clues about that? Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hussainakram @justin808 @cirosantilli