Skip to content

Updating JS node modules that are directly related to react (react, r… #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

tmobaird
Copy link
Contributor

@tmobaird tmobaird commented Aug 6, 2017

…edux, react-router, etc.)

@justin808 sorry for taking so long to get this done! I've been swamped recently.

I felt it would be taxing to update all dependencies in one fell swoop, so I chose to update the main react dependencies first (react, redux, react-router, prop-types).

Additions

  • Updated core ReactJS dependencies to the most recent versions. Modules updated:
    • react
    • react-addons-css-transition-group
    • react-bootstrap
    • react-dom
    • react-intl
    • react-redux
    • react-router
    • react-router-dom
  • Updated react-router strategy to use V4 practices (client and server side). Added specs for router's routes.
  • Added Prop Types library and extracted all PropType usage to come from this new library instead of react core.
  • Removed previous router history from store due to some structural changes that would probably need to be made to the store creation process to make this work with V4 (Here's an example of what the usage looks like with ConnectedRouter).

References #382.

Feel free to let me know if you have any suggestions! Thanks!


This change is Reviewable

@tmobaird tmobaird force-pushed the upgrade-dependencies branch from 79b3224 to c9c200d Compare August 6, 2017 08:20
@tmobaird
Copy link
Contributor Author

tmobaird commented Aug 6, 2017

@justin808 Looks like the build failed because Selenium couldn't connect to chromedriver during the specs:

Selenium::WebDriver::Error::WebDriverError:
  unable to connect to chromedriver 127.0.0.1:9515

It seems to be that something weird happened on travis. I'm not sure if there's a way to build this PR again, but all the tests should be passing.

I also saw that similar, and in some places overlapping, work is being made on #412. Please let me know what you would like me to do with this PR. Thanks!

@justin808
Copy link
Member

@tmobaird This is awesome. In regards to #412, I'm open to your suggestion on that one.

Since CI passes, I'm merging!


Reviewed 18 of 18 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants