hot reloading fix

[szyablitsky]

This returns styles for hot reloading and silences [sass-resources-loader]: options.context is missing. Using current working directory as a root instead error.

We do not need webpack.LoaderOptionsPlugin anymore, because all loaders used with individual options.

This change is 

[justin808]

Some questions. Looking good.

---

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

client/webpack.client.base.config.js, line 84 at r1 (raw file):

      options: {
        // Place here all postCSS plugins here, so postcss-loader will apply them
        postcss: [autoprefixer],

Do we need to specify this option elsewhere?

---

client/webpack.server.rails.build.config.js, line 78 at r1 (raw file):

            options: {
              resources: './app/assets/styles/app-variables.scss',
              context: __dirname,

Are we sure we want to remove this option?

---

client/yarn.lock, line 133 at r1 (raw file):

    sprintf-js "~1.0.2"

aria-query@^0.3.0:

why is this file changing?

---

config/database.yml, line 31 at r1 (raw file):

default: &default
  adapter: postgresql
  username: postgres

why is this changing?

---

Comments from Reviewable

[szyablitsky]

Answered questions. Will add commit with fixes in a minute.

---

Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

client/webpack.client.base.config.js, line 84 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Do we need to specify this option elsewhere?

It is already specified on every use of this loader explicitly.

---

client/webpack.server.rails.build.config.js, line 78 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Are we sure we want to remove this option?

Yes. This was a mistake. I think that @kaizencodes tried to get rid of [sass-resources-loader]: 'options.context' is missing. Using current working directory as a root insteaderror by adding this. This loader does not support this option. context is provided in https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/webpack.client.base.config.js#L15

---

client/yarn.lock, line 133 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

why is this file changing?

My mistake. I will remove it.

---

config/database.yml, line 31 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

why is this changing?

My mistake again. I will remove it.

---

Comments from Reviewable

[szyablitsky]

@justin808 fixed unneded changes

[justin808]

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[justin808]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

client/webpack.server.rails.build.config.js, line 78 at r1 (raw file):

Previously, szyablitsky (Sergey Zyablitsky) wrote…

Yes. This was a mistake. I think that @kaizencodes tried to get rid of [sass-resources-loader]: 'options.context' is missing. Using current working directory as a root insteaderror by adding this. This loader does not support this option. context is provided in https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/webpack.client.base.config.js#L15

OK

---

Comments from Reviewable