Update BaseComponent.jsx #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, I'm proposing a change in the BaseComponent as it seems to be using the `PureRenderMixin` mixin. The react docs states that we should consider using React.PureComponent instead, which essentially does the same shallow compare.
|
@robwise @alexfedoseev FYI...Agree? |
|
@justin808 Yes, absolutely. |
|
Thanks @cubadomingo Reviewed 1 of 1 files at r1, 3 of 3 files at r2. Comments from Reviewable |
|
If all the BaseComponent is doing is extending React.PureComponent, then why have BaseComponent at all? |
|
We could inline the usages of BaseComponent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'm proposing a change in the BaseComponent as it seems to be using the
PureRenderMixinmixin. The react docs states that we should consider using React.PureComponent instead, which essentially does the same shallow compare.This change is