Update all libraries and tests #334
Conversation
|
Anybody want to take this one? Comment in this thread. |
e59e82c to
f9f045e
Compare
|
Actually, updating react-bootstrap might fix the rspec failures, as there are many deprecation warnings. |
|
I'd like to help with this. I noticed that Travis is failing because selenium_firefox is not headless. A google search led me to https://docs.travis-ci.com/user/gui-and-headless-browsers/ and https://saucelabs.com/open-source. Do you think saucelabs would be a viable option for us or would you rather I focus on webkit and poltergeist? |
b63d64b to
12f9444
Compare
|
|
@Judahmeek Any progress on this one? |
Update mini-racer for Mac OS Sierra (#338) Updated linter to eslint-config-shakacode 13.0.0 Convert to latest react-bootstrap syntax fix scss lint Fixed a couple real bugs in the test and app code Tests passing locally with poltergeist.
bd3599a to
68e77f3
Compare
* https://github.com/heroku/rails_12factor#rails-5 says 12 factor not needed for heroku * Sqlite crashing on tests
ed7a88b to
89b1870
Compare
|
@Judahmeek I incorporated your changes, plus many more. |
| env: | ||
| global: | ||
| - RAILS_ENV=test | ||
| - CXX=g++-4.9 | ||
| - SAUCE_LABS_URL=http://judahmeek:[email protected]:80/wd/hub |
| - nvm install 6.3 | ||
| - nvm use 6.3 | ||
| - nvm install 6.7 | ||
| - nvm use 6.7 |
| gem "rspec-retry" | ||
| gem "selenium-webdriver", require: !["poltergeist", "poltergeist_errors_ok", "webkit"].include?(ENV["DRIVER"]) | ||
| gem "selenium-webdriver", "<3.0.0", require: !["poltergeist", "poltergeist_errors_ok", "webkit"].include?(ENV["DRIVER"]) |
There was a problem hiding this comment.
@Judahmeek why less than 3.0.0
There was a problem hiding this comment.
That was for sauce compatibility. They don't fully support Selenium 3 yet. Their docs certainly don't.
| # @selenium_chrome_registered = true | ||
| # end | ||
|
|
||
| def self.driver_caps(app) |
There was a problem hiding this comment.
remove sauce
so sauce can be a small PR so people can reference it
nobody wants to reference a 6K line PR
7d9c2d5 to
889154f
Compare
|
Sometimes passing!
|
|
@Judahmeek we can do the sauce thing as a separate PR |
This change is