Skip to content

Fix references between procfiles #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

roxolan
Copy link
Contributor

@roxolan roxolan commented May 2, 2016

It seems like Procfile.rails transmutated into Procfile.hot, didn't it? And it also is responsible for a part of what is declared in Procfile.dev.


This change is Reviewable

@justin808
Copy link
Member

Why is the README.md in the change list?

One comment and let's squash the commits and I'll merge.

Thanks @roxolan


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Procfile.hot, line 1 [r1] (raw file):
Let's add this to the end of the sentence:

using a webpack development server to load JavaScript and CSS


Comments from Reviewable

@roxolan
Copy link
Contributor Author

roxolan commented May 6, 2016

Thank you. README.md contains reference to the old Procfile.rails, which I thought was worth fixing (line 98). Emacs cleaned up some whitespace automatically, I hope it's ok, too.

@justin808
Copy link
Member

Please rebase to one commit on top of master. Thanks!

@roxolan
Copy link
Contributor Author

roxolan commented May 6, 2016

I am sorry, I'm not fully sure if I did everything right: I just updated the branch by merging. Would you like me to resubmit the whole thing in another pull request as just one commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants