Asset Tag Helpers API Change

[robwise]

• Change env_javascript_include_tag and env_stylesheet_link_tag API
• rename application_prod -> application_static
• rename application_dev to application_hot
• pass REACT_ON_RAILS_ENV='HOT' environment variable in Procfile.dev

[justin808]

no quotes

[robwise]

fixed

[justin808]

We need updates to the Procfiles:

Procfile.dev --- everything
Procfile.hot -- hot assets rails server for dev mode
Procfile.rails -- static assets rails server for dev mode
Procfile.express
Procfile.spec -- only if not doing Procfile.rails -- builds the file for specs

[justin808]

Then we want to put the helpers in react_on_rails.

[robwise]

@justin808 I still need to add the colored warning message thing we discussed, then will be ready for merge.

[robwise]

@justin808 ready for review/merge

[justin808]

Ready?

---

Reviewed 16 of 19 files at r1, 4 of 5 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

spec/support/ensure_assets_compiled.rb, line 8 [r3] (raw file):
@robwise when we move to this the generators, naturally, we don't put in the server part. We can check the config file REactOnRails to see if there's a server file. If you set to blank, that means no server rendering.

---

Comments from the review on Reviewable.io

[justin808]

Reviewed 16 of 19 files at r1, 4 of 5 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io