-
Notifications
You must be signed in to change notification settings - Fork 384
Fix ci build failures #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -40,7 +40,7 @@ rules: | |||
react/no-did-update-set-state: 0 | |||
react/no-multi-comp: 2 | |||
react/no-unknown-property: 2 | |||
react/prop-types: 1 | |||
react/prop-types: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really useful validation. There's some regression in eslint that's failing this.
At the min, we need to doc why we're doing this change temporarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justin808 did you read the link in my above comment about the github issue from the eslint-plugin-react
. Someone familiar with the react code should look at this and see if anything new in the code has triggered this issue? Or is still a bug in the plugin. Maybe you folks can try another react-props eslint plugin?
@justin808 Thanks to @josiasds for debugging the the react code that was causing the |
Still don't know why it was failing the linter though 😐 |
I think now we're good to merge this @dylangrafmyre @justin808 |
@justin808, @robwise, @alexfedoseev
I was able to fix the failing Travis CI build with setting Travis to install package
g++-4.9
.However, I fixed the failing Codeship build by setting
react/prop-types: 0
within.eslintrc
.This was the build fail issue:
And referenced here in the issues for
eslint-plugin-react
:jsx-eslint/eslint-plugin-react#9
I am sure you will not want to have this rule continually ignored; therefore, someone will need to address the issue in the code?
Thanks,
Dylan