enable react animations for comments list #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justin808 build is broken. there is some issue with eslint-plugin-react and I can't find out why. |
|
Please rebase this on master -- we've fixed this issue. |
must use unique id as key. Don't work with map's index.
enable animations with hot loading on port 4000
3a0c3db to
fe1c4d4
Compare
|
Done 👍 |
|
Looks good! |
justin808
added a commit
that referenced
this pull request
Dec 5, 2015
enable react animations for comments list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finishing the work on #155