enable react animations for comments list #155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
must use unique id as key. Don't work with map's index.
enable animations with hot loading on port 4000
Just a fixing a mistake
|
I believe ReactCSSTransitionGroups will throw console warnings still. It was discovered in 0.14.0, and sadly not yet fixed in 0.14.2 (it will be in 0.14.3). Do you see warnings in your console when you do the animations? |
|
no warnings... checked on both 3000 and 4000 ports. I just don't know how to fix the issues on travis. |
|
Huh.. interesting/good. This is the issue I was referring to: |
|
|
||
| var comments = [ | ||
| { author: 'Pete Hunt', text: 'Hey there!' }, | ||
| { author: 'Justin Gordon', text: 'Aloha from @railsonmaui' }, | ||
| { author: 'Pete Hunt', text: 'Hey there!', id: uuid.v4() }, |
There was a problem hiding this comment.
we need a unique id for list animations
|
Hi @thiagoc7. Maybe rebase on top of master and let me know what the next step is. |
|
Finished on #164. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just following the guide, and using the same
elementclass that already exist.