-
-
Notifications
You must be signed in to change notification settings - Fork 458
Move Images to img Directory #802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
=======================================
Coverage 80.23% 80.23%
=======================================
Files 57 57
Lines 1862 1862
Branches 410 410
=======================================
Hits 1494 1494
Misses 310 310
Partials 58 58 Continue to review full report at Codecov.
|
README.md
Outdated
@@ -381,7 +381,7 @@ myNextApplication: | |||
apiLambda: "nodejs10.x" | |||
``` | |||
|
|||
Similarly, the timeout by default is 10 seconds. To customise you can: | |||
Similarly, the timeout by default is 10 seconds. To customize you can: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! This is actually not a typo, as the original author of this package @danielcondemarin is based in the UK and these are the British spellings 😛.
I'm fine with reorganizing the images though, since there are a lot of files now in the repository root.
README.md
Outdated
@@ -421,7 +421,7 @@ The third is associated to a lambda function which is responsible for handling t | |||
|
|||
1. Server side rendered page. Any page that defines `getInitialProps` method will be rendered at this level and the response is returned immediately to the user. | |||
|
|||
2. Statically optimised page. Requests to pages that were pre-compiled by next to HTML are forwarded to S3. | |||
2. Statically optimized page. Requests to pages that were pre-compiled by next to HTML are forwarded to S3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for optimised
@dphang Thanks for the feedback. I've removed my typo fixes. :) |
Thanks! I will approve and merge it after the CI passes. |
This PR includes the following: