Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

Conversation

kirkness
Copy link
Collaborator

It's quite often the case that you need to access the underlying resources, for example, to update their roles or to read their configuration to pass into another resource. This PR exposes all created resources as properties on the construct. It also allows users to pass in custom S3 configuration.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #955 (06403b8) into master (650f8ac) will increase coverage by 0.00%.
The diff coverage is 87.50%.

❗ Current head 06403b8 differs from pull request most recent head 7f93288. Consider uploading reports for the commit 7f93288 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #955   +/-   ##
=======================================
  Coverage   81.39%   81.40%           
=======================================
  Files          69       69           
  Lines        2516     2517    +1     
  Branches      599      600    +1     
=======================================
+ Hits         2048     2049    +1     
  Misses        401      401           
  Partials       67       67           
Impacted Files Coverage Δ
...rless-components/nextjs-cdk-construct/src/index.ts 94.33% <87.50%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650f8ac...7f93288. Read the comment docs.

@dphang
Copy link
Collaborator

dphang commented Mar 21, 2021

LGTM!

@dphang dphang merged commit 026901b into master Mar 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/custom-s3-props-943 branch March 21, 2021 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants