This repository was archived by the owner on Jan 28, 2025. It is now read-only.
feat(lambda-at-edge): add minifyHandlers input to minify handler code using Terser #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphang
commented
Oct 8, 2020
| @@ -20,221 +24,280 @@ describe("Builder Tests", () => { | |||
| const fixturePath = join(__dirname, "./simple-app-fixture"); | |||
| const outputDir = join(fixturePath, ".test_sls_next_output"); | |||
|
|
|||
| beforeEach(async () => { | |||
There was a problem hiding this comment.
The original tests are not changed, not sure why git diff is this way
dphang
commented
Oct 8, 2020
| regex: expect.any(String) | ||
| } | ||
|
|
||
| it("default handler is not minified", async () => { |
dphang
commented
Oct 8, 2020
| "index.js" | ||
| ]); | ||
| expect(customerPages).toEqual(["[...catchAll].js", "[post].js"]); | ||
| it("API handler is not minified", async () => { |
dphang
commented
Oct 8, 2020
| describe("API Handler Artefact Files", () => { | ||
| it("copies build files", async () => { | ||
| expect.assertions(2); | ||
| describe("Minified handlers build", () => { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default handlers are not minified, but with
minifyHandlerswe can use the minified versions of handlers (pre-built into the package, so it won't add any time to the deployment), which reduces handler from 500 kB to 200 kB. It may also improve performance slightly.Tests
Added tests, also manually tested on e2e test app.