This repository was archived by the owner on Jan 28, 2025. It is now read-only.
Adding manual ACM SSL ARN specification. #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention that I performed tests, including the E2E specified in the contributor's doc. Everything seemed to pass. |
dphang
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
LGTM! Thanks for running the e2e tests. In the future, I will make it easier to run (e.g maintainers can manually trigger them using workflow dispatch event. Unfortunately we can't run it automatically for fork PRs as it requires AWS access keys, which forks do not have access to).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Did a quick patch to allow manual ACM cert specification as I wanted it to use a wildcard cert that I had already generated. It is a pretty simple change, adding a
certificateArninput variable and then processing if it was provided to avoid the search loop. Likely could do with some more logic checks, but since it still runs through the rest of the checks from the domain search, it seemed that keeping it minimal was better.