This repository was archived by the owner on Jan 28, 2025. It is now read-only.
Move config referencing out of plugin constructor #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mike-suggitt
commented
Nov 28, 2019
- Move constructor code into hooks wrapper so that config parsing and setup is done in hooks rather than constructor. This allows for serverless variable interpolation to happen before the plugin executes.
merge upstream
…actice and allows for variable interpolation to happen before execution. - Updated unit tests accordingly
danielcondemarin
approved these changes
Nov 30, 2019
|
Cheers @mike-suggitt 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.