BENCH: rationalize slow benchmarks + miscellaneous fixes #9235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forming the random matrices is quite slow, so cache the results.
This can be done simply in setup(), because every benchmark runs in a separate process.
The version numbers are copypasted from previous results/benchmarks.json. If the benchmarks are changed in the future substantially, the .version attributes can be removed. If they are changed without affecting the results, the .version can stay the same.
|
would be good to put the description of what |
|
OK, added short description. |
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python 3 bugs.
Skip slowest "comparison" benchmarks, which e.g. benchmark numpy routines or non-relevant scipy routines.
Limit the problem sizes for which some benchmarks are run, in order to reduce runtime.
Rewrite benchmarks/sparse.NullSlice setup() in a faster way.
Fix bugs in benchmark code.
Set benchmark version numbers, so that the changes won't invalidate old results. They don't need to be kept in sync with anything or updated in the future. (asv only looks if the
.versionattribute changes, it doesn't care what is in it. The values here are copypasted from results/benchmarks.json --- they come from the default behavior of hashing the source code for setup() and time_*().)I didn't look here at benchmarks/spatial.py, maybe there's something to fix also there.
First look at gh-9225, trying to fix the worst offenders...
[no ci] / canceled manually