BUG: signal: fix crash in lfilter #8010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Oct 10, 2017
ghost
reviewed
Oct 10, 2017
| #if PY_VERSION_HEX >= 0x03000000 | ||
| msg = PyUnicode_FromFormat( | ||
| "input type '%U' not supported\n", str); | ||
| #else | ||
| s = PyString_AsString(str); |
There was a problem hiding this comment.
Question: how would this compile on Python 3? PyString_AsString is not a function.
There was a problem hiding this comment.
there are compat defines (edit: removed now, weren't used elsewhere, so obviously they were completely useless)
ghost
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7991