MAINT: special: Mark a test that fails on i686 as a known failure. #7937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation `special.fdtri(1, 1, 0.5)` sometimes returns nan on i686 systems. Before the change in scipy#7919, the test suite had this comment: # cephes.fdtri(1,1,0.5) #BUG: gives NaN, should be 1 but there was no issue for tracking the problem. That test was restored in scipygh-7919, and it passes on 64 bit architectures. This change makes that calculation a separate test that is marked as a known failure. The github issue for this test is now scipygh-7931.
|
Let's unbreak the daily builds on https://travis-ci.org/MacPython/scipy-wheels/builds, in it goes. |
|
Thanks Warren |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation
special.fdtri(1, 1, 0.5)sometimes returns nan on i686systems. Before the change in #7919,
the test suite had this comment:
but there was no issue for tracking the problem. That test was restored
in gh-7919, and it passes on 64 bit architectures.
This change makes that calculation a separate test that is marked as a
known failure. The github issue for this test is now gh-7931.