BUG: Fix return dtype for complex input in spsolve #6908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f024022 to
0da0391
Compare
perimosocordiae
requested changes
Jan 1, 2017
| @@ -108,6 +108,11 @@ def spsolve(A, b, permc_spec=None, use_umfpack=True): | |||
|
|
|||
| A.sort_indices() | |||
| A = A.asfptype() # upcast to a floating point format | |||
| resultDType = np.promote_types(A.dtype, b.dtype) | |||
There was a problem hiding this comment.
this should probably be result_dtype, to match the surrounding style
| [0, 0, 3], | ||
| [4, 0, 5 + 1j]]) | ||
| bReal = np.array([1,1,1]) | ||
| bComplex = np.array([1,1,1]) + 1j*np.array([1,1,1]) |
There was a problem hiding this comment.
same as above, these should be A_real, A_complex, b_real, b_complex
added 2 commits
January 1, 2017 21:32
Added test case that complex input for the matrix or the vector results in a complex solution.
Complex input for either the matrix A or the vector b should give a complex vector as a result. This fixes scipy#6901.
0da0391 to
a1485a6
Compare
|
@perimosocordiae Oh yes, thanks you are obviously right. It's my first time contributing and apparently I am too used to camel code. I changed the style to match the surrounding code. |
perimosocordiae
approved these changes
Jan 2, 2017
|
Looks good to me. I'll wait a few days to let another maintainer have a look before merging. |
|
LGTM too, merged. Thanks @jotasi, @perimosocordiae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex input for either the matrix A or the vector b should give a complex vector as a result. Tests are added to ensure this. The fix is done in the fashion suggested by @perimosocordiae. This fixes #6901.