MAINT: stats: move creation of namedtuples outside of function call. #5414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of scipygh-5368. Fixes performance regression in 0.16.0
|
All green. If someone wants to have a quick look, that would be great. I'll start on the backport and building binaries. |
|
Looks good, merging. Thanks Ralf! |
ev-br
added a commit
that referenced
this pull request
Oct 24, 2015
MAINT: stats: move creation of namedtuples outside of function call.
rgommers
added a commit
to rgommers/scipy
that referenced
this pull request
Oct 24, 2015
Backport of scipygh-5368 and scipygh-5414. Note that backport was manual (changes between master and 0.16.x too extensive to cherry-pick), so there may be minor stylistic differences between this commit and the PRs.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of gh-5368. Fixes performance regression in 0.16.0