Skip to content

MAINT: Correct odeint messages #4662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2015
Merged

MAINT: Correct odeint messages #4662

merged 1 commit into from
Apr 4, 2015

Conversation

vermelha
Copy link
Contributor

accordind to issue #4565 odeint is writing messages to standard output. Change to use warnings for messages.

@rgommers rgommers added scipy.integrate maintenance Items related to regular maintenance tasks labels Mar 23, 2015
@ev-br ev-br added the needs-work Items that are pending response from the author label Apr 1, 2015
@vermelha
Copy link
Contributor Author

vermelha commented Apr 2, 2015

Well, it wasn't a good idea to change global settings indeed.
What I see is just a need to remove this line:

warnings.simplefilter('always')

In the original issue #4565 it was mentioned that 'There should also be an option to "silence" it.'
It seems that changing warnings filter to "ignore" state will silence them without the need to add a new parameter to odeint function. If it's OK I'll make a new commit.

@ev-br
Copy link
Member

ev-br commented Apr 2, 2015

I think it's best to make a new commit and squash them into one, git rebase -i HEAD~1 and then force-push the result.

odeint is writing messages to standard output. Change to use warnings for messages.
@vermelha
Copy link
Contributor Author

vermelha commented Apr 3, 2015

Done

@ev-br ev-br removed the needs-work Items that are pending response from the author label Apr 4, 2015
@ev-br
Copy link
Member

ev-br commented Apr 4, 2015

Not sure whether printmessg parameter is useful, but that can be done separately, and a change to use warnings instead of plain prints looks good. Merging, thanks @vermelha!

ev-br added a commit that referenced this pull request Apr 4, 2015
@ev-br ev-br merged commit a1bfecb into scipy:master Apr 4, 2015
@rgommers rgommers added this to the 0.16.0 milestone Apr 4, 2015
@vermelha
Copy link
Contributor Author

vermelha commented Apr 4, 2015

You are welcome! Thanks for help @ev-br!
I suppose I should delete the branch now...?

@rgommers
Copy link
Member

rgommers commented Apr 4, 2015

You don't have to, but it's indeed a good idea. I usually delete all merged branches to prevent my own repo becoming too messy.

@rgommers rgommers mentioned this pull request Apr 4, 2015
@rgommers
Copy link
Member

rgommers commented Apr 4, 2015

@vermelha if you include closes gh-4565 in your commit message next time, the issue will be closed automatically when the PR gets merged. Doesn't matter that it wasn't done here, but it's handy.

@vermelha
Copy link
Contributor Author

vermelha commented Apr 4, 2015

@rgommers, thanks for advices!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.integrate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants