Skip to content

MAINT: use reduction axis arguments in one-norm estimation #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

argriffing
Copy link
Contributor

This is a more focused subset of #4095.

benchmark information:

 ====== ========== ============
               --              solver        
               ------ -----------------------
                 n      exact     onenormest 
               ====== ========== ============
                 2      1.50ms      4.84ms   
                 3      1.74ms     43.26ms   
                 5      1.77ms     47.59ms   
                 10     1.82ms     51.76ms   
                 30     3.05ms     66.18ms   
                100    23.12ms     143.12ms  
                300    470.47ms    357.08ms  
                500     2.07s      638.53ms  
                1000     null       1.48s    


 ====== ========== ============
               --              solver        
               ------ -----------------------
                 n      exact     onenormest 
               ====== ========== ============
                 2      1.62ms      4.90ms   
                 3      1.62ms     37.43ms   
                 5      1.77ms     38.97ms   
                 10     1.84ms     39.22ms   
                 30     2.98ms     41.59ms   
                100    23.49ms     57.12ms   
                300    460.60ms    126.43ms  
                500     2.02s      237.10ms  
                1000     null      708.25ms  
               ====== ========== ============

@argriffing
Copy link
Contributor Author

I made this PR over three hours ago and TravisCI is just now getting around to running the tests...

@argriffing
Copy link
Contributor Author

Maybe I will merge this soon... it consists of internal implementation details of code that I had originally written myself, so it would be boring to review.

@ewmoore
Copy link
Member

ewmoore commented Feb 23, 2015

Yes. This is fine. Let's just take it.

ewmoore added a commit that referenced this pull request Feb 23, 2015
MAINT: use reduction axis arguments in one-norm estimation
@ewmoore ewmoore merged commit ad28a2e into scipy:master Feb 23, 2015
@rgommers rgommers added scipy.sparse.linalg maintenance Items related to regular maintenance tasks labels Feb 24, 2015
@rgommers rgommers added this to the 0.16.0 milestone Feb 24, 2015
@argriffing argriffing deleted the onenormest-speedup-retry branch February 24, 2015 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.sparse.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants