TST: a few changes like self.assertTrue(x == y, message) -> assert_equal(x, y) #4320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,8 +57,7 @@ def test_definition(self): | |||
| for i in FFTWDATA_SIZES: | |||
| x, yr = fftw_dct_ref(self.type, i, self.rdt) | |||
| y = dct(x, type=self.type) | |||
| self.assertTrue(y.dtype == self.rdt, | |||
| "Output dtype is %s, expected %s" % (y.dtype, self.rdt)) | |||
| assert_equal(y.dtype, self.rdt) | |||
There was a problem hiding this comment.
Might as well keep the error message; e.g.
assert_equal(y.dtype, self.rdt, "Output dtype is %s, expected %s" % (y.dtype, self.rdt))
There was a problem hiding this comment.
@WarrenWeckesser is that not pretty much the same error message given when equality fails anyway? Removing the error message also prevents the possibility of getting out of sync if the spelling of y.dtype or self.rdt ever changes.
There was a problem hiding this comment.
You're right, the message doesn't really add anything useful in this case. Never mind!
dlax
added a commit
that referenced
this pull request
Dec 28, 2014
TST: a few changes like self.assertTrue(x == y, message) -> assert_equal(x, y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the syntax of a few assertions.