Pr/3923 #4187
Merged
Pr/3923 #4187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curve_fit now raises ValueError if input data contains NaNs. Previously curve_fit would return nonsensical results.
pv
added a commit
that referenced
this pull request
Nov 23, 2014
ENH: optimize: handle NaNs in curve_fit
|
LGTM, this should be ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a suggested redo of gh-3923: this adds a
check_finiteflag tocurve_fit, modelled after a similar flag inlinalg. IMO having this flag is a reasonable price to pay for fixing the nonsense of gh-3422, but apparently, there is a range of opinions, see gh-3923 for discussion.I think it would be nice to fix the original issue, gh-3422, for 0.15.
This PR and gh-3925 provide slightly different ways of fixing it, and I personally would be fine with either of them.
And yeah, in case this is decided to be the one to be merged, github magic: closes gh-3923, fixes gh-3422