MAINT: add pyflakes to Travis-CI #3384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variables will receive their values during the running of the value.
The `types` and `r_mend` variables are undefined, making the routines tokenize_multilines and floupi inoperable.
There's no routine get_psolve. Just assume psolve is given.
Not bugs per se here, but let's make pyflakes happier.
|
Looks good to me. TravisCI errors look unrelated, but haven't seen that error before so re-run anyway. |
|
Note that you can rerun travis from the travis page, look for icon on the tab line. You can also rerun individual tests from their page. If you don't see those options, it may be that you have to join travis-ci. |
|
Ah yes. I looked for it, but I didn't sign in. Now it's asking me for write access on all my public Github data though, which I don't think I want it to have. |
rgommers
pushed a commit
that referenced
this pull request
Feb 25, 2014
MAINT: add pyflakes to Travis-CI
|
Works now, merging. Thanks Pauli. |
|
@rgommers I signed into Travis-CI today and its permissions have changed. It no longer asks for write access to your repos if I understand correctly. |
|
@cowlicks thanks, that looks much more reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static code checking can be useful in some cases, esp. catching missing imports and so on. Of the Python static checkers, pyflakes seems to do the least amount of opinion-based style checking, and seems the best for this purpose.
This PR adds pyflakes run to the automated test suite. I filter out most "assigned but unused" failures, as those shouldn't result to Travis failures.
I also fix some issues it finds. Mainly harmless, although some of them were actual bugs.