MAINT: compensate for dot exceptions #22726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes scipygh-22720. * This patch adds a few floating point exception handling shims to compensate for the upstream change for `np.dot` at numpy/numpy#28442, merged five days ago. This allows the Scipy testsuite to pass again locally on x86_64 Linux against NumPy `main`.
|
Going to merge this to free up CI. Am not sure if the contextmanager is threadsafe, but we can mark the test if it comes to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MAINT, CI: floating point exceptions activated in NumPy #22720.
This patch adds a few floating point exception handling shims to compensate for the upstream
change for
np.dotat ENH: Check for floating point exceptions in dot numpy/numpy#28442, merged five days ago. This allows the SciPy testsuite to pass again locally on x86_64 Linux against NumPymain.