BUG: optimize.root_scalar: let bracket be passed as a NumPy array
#21116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method used by `root_scalar` depends on the optional arguments passed to the function. Whether `bracket` is passed is tested by evaluating its truthiness. That raises a `ValueError` if `bracket` is passed as a numpy array. This commit fixes this by testing `bracket` against `None`.
|
this looks correct to me, although I'm not sure whether the documented type "sequence" has a more precise meaning historically. |
dschmitz89
approved these changes
Jul 6, 2024
optimize.root_scalar: let bracket be passed as a NumPy array
|
Thanks @tartopohm . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The method used by
root_scalardepends on the optional arguments passed to the function. Whetherbracketis passed is tested by evaluating its truthiness. That raises aValueErrorifbracketis passed as a numpy array:ValueError: The truth value of an array with more than one element is ambiguous.This commit fixes this by testing
bracketagainstNone, and adds a simple test to check that the root obtained when passingbracketas an array is correct.Additional information
A check was already in place within
root_scalarto verifybracketis a list, tuple, or np.ndarray, which led me to believe passing the parameter as a np.ndarray should be accepted by this function.