Skip to content

MAINT: gcc-14 test_region5 tol bump #21063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

tylerjereddy
Copy link
Contributor

[ci skip] [skip ci]

* Fixes scipy#21059

* A small tolerance bump in `TestHyp2f1.test_region5` needed for one
its test cases to pass when compiling SciPy with gcc-14 series.

[ci skip] [skip ci]
@tylerjereddy tylerjereddy added scipy.special maintenance Items related to regular maintenance tasks labels Jun 27, 2024
@tylerjereddy tylerjereddy added this to the 1.15.0 milestone Jun 27, 2024
Copy link
Contributor

@steppi steppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely due to a compiler optimization shuffling some arithmetic operations in a way that changes the value. Bumping the tolerance here seems fine to me.

@steppi steppi merged commit 485b26d into scipy:main Jun 27, 2024
1 check passed
@tylerjereddy tylerjereddy deleted the treddy_issue_21059 branch June 27, 2024 17:41
@lucascolley lucascolley changed the title MAINT: gcc-14 test_region5 tol bump MAINT: gcc-14 test_region5 tol bump Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.special
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST, MAINT: TestHyp2f1.test_region5 tol issue with gcc 14.1.0
2 participants