BLD: avoid setting an environment variable in a meson.build file #20450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced last month in scipygh-20232; I commented on it there about it maybe being able to cause an issue later. And it just did, see scipygh-20433. Upgrading Meson in an existing build environment is technically unsupported by Meson, but has always "just worked". Now we hit a corner case on Windows, because when we set an environment variable in a `meson.build` file, a pickled version of Meson is called and this is less robust to upgrading Meson in the build env. The fix is a bit more verbose, but should be reliable - the `importlib` importing is directly copied from how it's done in NumPy's code generation scripts.
65e0055 to
bdc4a22
Compare
|
Interesting indeed. No idea how I end up hitting these corners on Windows but thank you for the surgery anyways. |
|
I should’ve known better haha. Thanks for the fix @rgommers! |
|
Feel free to use the green button @thalassemia ;) |
thalassemia
approved these changes
Apr 11, 2024
It's not you, it's Windows :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced last month in gh-20232; I commented on it there (https://github.com/scipy/scipy/pull/20232/files#r1524677014) about it maybe being able to cause an issue later. And it just did, see gh-20433. Upgrading Meson in an existing build environment is technically unsupported by Meson, but has always "just worked". Now we hit a corner case on Windows, because when we set an environment variable in a
meson.buildfile, a pickled version of Meson is called and this is less robust to upgrading Meson in the build env.The fix is a bit more verbose, but should be reliable - the
importlibimporting is directly copied from how it's done in NumPy's code generation scripts.