BUG: Use raw strings for paths in __config__.py.in
#17936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `\U` leads to strings being treated as unicode, hence we escape it with raw strings * Changed bool parameters real bools instead of string `"True"` and `"False"` [wheel build]
|
It seems these are the build time python and include file paths. Is that going to be relevant for end users? |
|
@mattip, probably not. |
|
Thank you @ganesh-k13. |
|
@tylerjereddy I think this has to be backported to allow the Windows wheels to be built, otherwise the wheel tests fail. |
|
@andyfaff Indeed, thanks, the Windows wheel failures were observed in the backport PR cross-linked above. |
ganesh-k13
added a commit
to ganesh-k13/numpy
that referenced
this pull request
Feb 17, 2023
* `\U` leads to strings being treated as unicode, hence we escape it with raw strings * Changed bool parameters real bools instead of string `"True"` and `"False"` * Small refactor in `_cleanup` to make it consistent with SciPy Taken from scipy/scipy#17936
2 tasks
rgommers
added a commit
to rgommers/scipy
that referenced
this pull request
Jan 22, 2024
Reported in conda-forge/scipy-feedstock#264: linker args contained a `\s` on Windows as part of a path in a linker flag. This is basically the same bug as scipygh-17936, it was fixed for paths in `__config__.py` but not for things like linker flags which usually don't contain a path but may do so. Now turn everything except name/version/found/id, which really should not contain escapes, into raw strings. [skip circle] [skip cirrus]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
resolves #17934
What does this implement/fix?
\Uleads to strings being treated as unicode, hence we escape it with raw strings"True"and"False"Additional information
__config__generation #17862[backport-candidate], please mark this for backport as well (I cannot add labels)