Skip to content

DOC: corrected doc of bilinear discretization of lti #17922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Conversation

zolabar
Copy link
Contributor

@zolabar zolabar commented Feb 3, 2023

Reference issue

Closes #17911

What does this implement/fix?

The Tustin formula in

https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.bilinear.html

is described as (z-1) / (z+1)

but it should be fs*2*(z-1) / (z+1)

Additional information

https://en.wikipedia.org/wiki/Bilinear_transform

@tupui tupui changed the title corrected doc of bilinear discretization of lti DOC: corrected doc of bilinear discretization of lti Feb 3, 2023
@tupui tupui added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label Feb 3, 2023
@tupui tupui added this to the 1.11.0 milestone Feb 3, 2023
@ilayn
Copy link
Member

ilayn commented Feb 3, 2023

Thanks @zolabar I also added bilinear_zpk to the fix suffering from the same thing. We can merge once the CI is done.

@zolabar
Copy link
Contributor Author

zolabar commented Feb 3, 2023

Thanks @zolabar I also added bilinear_zpk to the fix suffering from the same thing. We can merge once the CI is done.

Perfect 🙂

@ilayn ilayn merged commit 4790628 into scipy:main Feb 4, 2023
@ilayn
Copy link
Member

ilayn commented Feb 4, 2023

Thanks once again!

@zolabar
Copy link
Contributor Author

zolabar commented Feb 4, 2023

Thanks once again!

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.signal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Formula of Tustin formula in scipy.signal.bilinear misses "fs*2"
3 participants