MAINT: optimize.toms748: don't do newton after secant interpolation #17732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupui
approved these changes
Jan 6, 2023
windows-server-2003
pushed a commit
to windows-server-2003/scipy
that referenced
this pull request
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-13535
What does this implement/fix?
This stops TOMS748 from performing newton iteration after secant interpolation as suggested in gh-13535.
The relevant excerpt from the original paper is:
$A\neq 0$ ; otherwise it would have been "if $A=0$ , then $r_0 = ...$ ", but they wrote $r = ...$.
It's not immediately obvious, but reading closely looks like they meant for the iterative procedure to execute only if
Additional information
No tests are needed; the old tests were sufficient and they still pass.
@pvanmulbregt This implements your recommendation from gh-13535. Does this close the issue?