ENH: optimize.root_scalar: allow newton without f', secant without x1 #17691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
commented
Jan 1, 2023
|
No test failed (because of this PR) after the second commit, and the last commit made a minor tweak to the documentation, so I skipped CI. |
|
@andyfaff looks like this might merge, but still let us know if there's an issue. There's plenty of time to change it before the next release. |
|
Merging tomorrow. |
This was referenced May 24, 2023
nickodell
added a commit
to nickodell/scipy
that referenced
this pull request
Jul 14, 2024
Since scipygh-17691, it is no longer required to provide x1. Document this. [docs only]
lucascolley
added a commit
that referenced
this pull request
Jul 14, 2024
* DOC: Mark x1 as optional for secant root finding Since gh-17691, it is no longer required to provide x1. Document this. [docs only] --------- Co-authored-by: Lucas Colley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-17570
What does this implement/fix?
root_scalardoes not allowmethod='newton'to be used without an analytical derivative even thoughscipy.optimize.rootdoes, and it does not allowmethod='secant'to be used without an explicitx1even thoughscipy.optimize.newtondoes. This PR removesroot_scalar's restrictions on use of these methods and updates the defaults method resolution accordingly.Additional information
I don't think there are any BC concerns because it is documented that
